Skip to content

GH-137841: Open tzdata/zones file with UTF-8 encoding#137872

Merged
AA-Turner merged 1 commit into
python:mainfrom
AA-Turner:zoneinfo-tzdata
Aug 17, 2025
Merged

GH-137841: Open tzdata/zones file with UTF-8 encoding#137872
AA-Turner merged 1 commit into
python:mainfrom
AA-Turner:zoneinfo-tzdata

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Aug 17, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@AA-Turner AA-Turner requested a review from pganssle August 17, 2025 04:44
@bedevere-app bedevere-app Bot mentioned this pull request Aug 17, 2025
Closed
serhiy-storchaka
serhiy-storchaka approved these changes Aug 17, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

auvipy
auvipy approved these changes Aug 17, 2025
View reviewed changes

@auvipy auvipy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes make sense. and looks good

@AA-Turner AA-Turner merged commit 25b9728 into python:main Aug 17, 2025
50 checks passed
@AA-Turner AA-Turner deleted the zoneinfo-tzdata branch August 17, 2025 16:14
@AA-Turner

AA-Turner commented Aug 17, 2025

Copy link
Copy Markdown
Member Author

Is it worth backporting this?

@auvipy

auvipy commented Aug 18, 2025

Copy link
Copy Markdown

I think it should be backported to python 3.14

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@AA-Turner @Agent-Hellboy
pythonGH-137841: Open tzdata/zones file with UTF-8 encoding (python#1…
97571fd 
…37872)
@mtelka

mtelka commented Nov 15, 2025

Copy link
Copy Markdown
Contributor

Can we get this backported to Python 3.14 please?

@AA-Turner AA-Turner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 16, 2025
@miss-islington-app

miss-islington-app Bot commented Nov 16, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Nov 16, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2025
@AA-Turner @miss-islington
pythonGH-137841: Open tzdata/zones file with UTF-8 encoding (pythonGH…
9e0ebac 
…-137872)

(cherry picked from commit 25b9728)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Nov 16, 2025

Copy link
Copy Markdown

GH-141607 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 16, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2025
@AA-Turner @miss-islington
pythonGH-137841: Open tzdata/zones file with UTF-8 encoding (pythonGH…
37e447a 
…-137872)

(cherry picked from commit 25b9728)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Nov 16, 2025

Copy link
Copy Markdown

GH-141608 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Nov 16, 2025
hugovk pushed a commit that referenced this pull request Nov 20, 2025
@miss-islington @AA-Turner
[3.13] GH-137841: Open tzdata/zones file with UTF-8 encoding (GH-137872…
ad9f2ed 
…) (#141608)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
hugovk pushed a commit that referenced this pull request Nov 20, 2025
@miss-islington @AA-Turner
[3.14] GH-137841: Open tzdata/zones file with UTF-8 encoding (GH-137872…
1253a8b 
…) (#141607)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
+1 more reviewer
@auvipy auvipy auvipy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AA-Turner @auvipy @mtelka @methane @serhiy-storchaka